Many PR like this have been refused before.

Why?

#8682 (comment)

a referral to a comment that says the same thing, doesn't validate the refusal. I can understand not wanting to accept because of $reason, but at least provide a link to a valid reason.

Graham will give you one

Le samedi 18 juin 2016, Michael Beckwith notifications@github.com a
écrit :

a referral to a comment that says the same thing, doesn't validate the
refusal. I can understand not wanting to accept because of $reason, but at
least provide a link to a valid reason.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#14036 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfWQ7PJVztTUAXYHKiUAlepEGruQn7gks5qM5pHgaJpZM4I44z5
.

Both this change, and the reverse make valid pull requests. Thanks, but we won't be merging PRs like this.

What the reasoning behind that? It's a tiny change that breaks no logic and improves the code readability. Things like this are the easiest way for new developers to start contributing to OSS. I'm interested in why one of the largest frameworks in the ecosystem would deny requests like this with no further explanation.

you can't fight egoist bastards. start your own project.

@midorikocak this could simply be a failure to communicate. I don't think insults are called for or even helpful at this point.

@GrahamCampbell is it fair to say that only those with merge rights to this repo are allowed to contribute subjective/style-based changes. Everything else needs to be a functional change?

Thank you, but as I said, we're not looking to merge changes like this. I wrote StyleCI to automate our code style so we don't ever have to waste time processing code style issues again.

Graham isn't even supposed to be closing or merging PRs in the first place as I've told him multiple times so not sure why this is closed. That's something I can discuss with him privately. I am the only one who is supposed to either close or merge a PR.

Thanks for the PR.

Thanks, @taylorotwell!

Really sorry everyone. I really didn't mean to upset anyone here.

Sometimes being welcoming to contributions is more important than sticking to rules and guidelines.

Totally agree. Really sorry I processed this in this way. In future, I will not be closing any PRs at all.